Fix abbrevation tips to work with vi mode #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just tested this and it fixed #4 for me. Takkâ! Edit: just to clarify, I do use vi mode with fish. |
|
Hi @madk38! Good catch on this one! Looks good to me, I'will merge it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Default bind mode in fish is
defaultwhich is stored in$fish_bind_modevariable. By defaultbindcommand binds keys indefaultmode.After enabling vi keybindings in fish, mode can be toggled between both
insertmode anddefaultmode.Thus, the bindings don't work for vi keybindings as we are normally in
insertmode.This PR will enable abbrevation-tips binds in vi mode.
Related issues
This might solve issue #4, but I am not sure, as it is working unexpectedly sometimes #4 (comment)
Notes